Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/docker/docker from 20.10.7+incompatible to 24.0.9+incompatible in /flytectl #5305

Closed
wants to merge 1 commit into from
Closed

Bump github.com/docker/docker from 20.10.7+incompatible to 24.0.9+incompatible in /flytectl #5305

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 30, 2024 •
edited
Loading

Bumps github.com/docker/docker from 20.10.7+incompatible to 24.0.9+incompatible.

Release notes

Sourced from github.com/docker/docker's releases.

v24.0.9

24.0.9

For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones:

Security

This release contains security fixes for the following CVEs affecting Docker Engine and its components.

CVE Component Fix version Severity
CVE-2024-21626 runc 1.1.12 High, CVSS 8.6
CVE-2024-24557 Docker Engine 24.0.9 Medium, CVSS 6.9

Important ⚠️

Note that this release of Docker Engine doesn't include fixes for the following known vulnerabilities in BuildKit:

To address these vulnerabilities, upgrade to Docker Engine v25.0.2.

For more information about the security issues addressed in this release, and the unaddressed vulnerabilities in BuildKit, refer to the blog post. For details about each vulnerability, see the relevant security advisory:

Packaging updates

v24.0.8

24.0.8

For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones:

Bug fixes and enhancements

  • Live restore: Containers with auto remove (docker run --rm) are no longer forcibly removed on engine restart. moby/moby#46857

... (truncated)

Commits
  • fca702d Merge pull request from GHSA-xw73-rw38-6vjc
  • f78a772 Merge pull request #47281 from thaJeztah/24.0_backport_bump_containerd_binary...
  • 61afffe Merge pull request #47270 from thaJeztah/24.0_backport_bump_runc_binary_1.1.12
  • b38e74c Merge pull request #47276 from thaJeztah/24.0_backport_bump_runc_1.1.12
  • dac5663 update containerd binary to v1.7.13
  • 20e1af3 vendor: github.com/opencontainers/runc v1.1.12
  • 858919d update runc binary to v1.1.12
  • 141ad39 Merge pull request #47266 from vvoland/ci-fix-makeps1-templatefail-24
  • db968c6 hack/make.ps1: Fix go list pattern
  • 61c51fb Merge pull request #47221 from vvoland/pkg-pools-close-noop-24
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 30, 2024
@ddl-ebrown
Copy link
Contributor

@eapolinario if you could merge this one that would be great - thanks! It includes a number of CVE resolutions.

@dependabot dependabot bot force-pushed the dependabot/go_modules/flytectl/github.com/docker/docker-24.0.9incompatible branch 2 times, most recently from 6d5debd to a5f970c Compare May 2, 2024 22:38
@ddl-ebrown
Copy link
Contributor

@dependabot recreate

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github May 3, 2024

Sorry, only users with push access can use that command.

@ddl-ebrown
Copy link
Contributor

Sorry, only users with push access can use that command.

Ah well, I tried!

@eapolinario
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/flytectl/github.com/docker/docker-24.0.9incompatible branch from 762a4e1 to e8b3d48 Compare May 3, 2024 22:07
@eapolinario
Copy link
Contributor

@ddl-ebrown , jumping 4 major versions of docker brought in some incompatibilities. We'll need to invest time in updating the code to use the new docker API. Do you want to take a crack at it?

@dependabot dependabot bot force-pushed the dependabot/go_modules/flytectl/github.com/docker/docker-24.0.9incompatible branch from e8b3d48 to 356a774 Compare May 7, 2024 18:16
@ddl-ebrown
Copy link
Contributor

@eapolinario I should be able to take care of that.

How will the binary ship now that it's in the monorepo?

@eapolinario
Copy link
Contributor

@eapolinario I should be able to take care of that.

Thank you!

How will the binary ship now that it's in the monorepo?
I'm working on a change to enable us to ship flytectl from the monorepo using goreleaser. It'll be a workflow we run manually in the beginning. Once that change is out I'm going to archive the flytectl repo.

@dependabot
Bump github.com/docker/docker in /flytectl
8e066b6 
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.7+incompatible to 24.0.9+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v20.10.7...v24.0.9)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/flytectl/github.com/docker/docker-24.0.9incompatible branch from 356a774 to 8e066b6 Compare May 9, 2024 08:06
@ddl-ebrown ddl-ebrown mentioned this pull request May 14, 2024
Merged
3 tasks
@ddl-ebrown
Copy link
Contributor

Can be closed in favor of #5363 which fixes the compilation @eapolinario. Thanks!

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github May 15, 2024

Looks like github.com/docker/docker is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this May 15, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/flytectl/github.com/docker/docker-24.0.9incompatible branch May 15, 2024 01:07
@runllm runllm bot mentioned this pull request Aug 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddl-ebrown ddl-ebrown ddl-ebrown approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddl-ebrown @eapolinario